[llvm-branch-commits] [clang] [llvm] [HLSL] Add GetDimensions to Texture2D. (PR #189991)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Wed Apr 1 09:06:44 PDT 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-llvm-ir
Author: Steven Perron (s-perron)
<details>
<summary>Changes</summary>
This commit add the GetDimensions mehtods to Texture2D. For DXIL, it
requires intrinsics that are not yet available. They are added, but not
implemented.
Assisted-by: Gemini
<!-- branch-stack-start -->
-------------------------
- main
- https://github.com/llvm/llvm-project/pull/188574
- https://github.com/llvm/llvm-project/pull/189746
- users/s-perron/texture2d-get-dimension-hlsl :point_left:
<sup>[Stack](https://www.git-town.com/how-to/proposal-breadcrumb.html) generated by [Git Town](https://github.com/git-town/git-town)</sup>
<!-- branch-stack-end -->
---
Patch is 44.37 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/189991.diff
15 Files Affected:
- (modified) clang/include/clang/Basic/Builtins.td (+30)
- (modified) clang/lib/CodeGen/CGHLSLBuiltins.cpp (+65-6)
- (modified) clang/lib/CodeGen/CGHLSLRuntime.h (+3)
- (modified) clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp (+47)
- (modified) clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.h (+1)
- (modified) clang/lib/Sema/HLSLExternalSemaSource.cpp (+1)
- (modified) clang/test/AST/HLSL/Texture2D-scalar-AST.hlsl (+88)
- (modified) clang/test/AST/HLSL/Texture2D-vector-AST.hlsl (+84)
- (modified) clang/test/CodeGenHLSL/resources/ByteAddressBuffers-methods.hlsl (+2-2)
- (modified) clang/test/CodeGenHLSL/resources/StructuredBuffers-methods-lib.hlsl (+3-3)
- (modified) clang/test/CodeGenHLSL/resources/StructuredBuffers-methods-ps.hlsl (+2-2)
- (added) clang/test/CodeGenHLSL/resources/Texture2D-GetDimensions.hlsl (+103)
- (modified) clang/test/CodeGenHLSL/resources/TypedBuffers-methods.hlsl (+2-2)
- (added) clang/test/SemaHLSL/Resources/Texture2D-GetDimensions.hlsl (+80)
- (modified) llvm/include/llvm/IR/IntrinsicsDirectX.td (+4)
``````````diff
diff --git a/clang/include/clang/Basic/Builtins.td b/clang/include/clang/Basic/Builtins.td
index a1afa82955f6a..b8bbc544595e2 100644
--- a/clang/include/clang/Basic/Builtins.td
+++ b/clang/include/clang/Basic/Builtins.td
@@ -5138,6 +5138,36 @@ def HLSLResourceGetDimensionsX : LangBuiltin<"HLSL_LANG"> {
let Prototype = "void(__hlsl_resource_t, uint32_t&)";
}
+def HLSLResourceGetDimensionsXY : LangBuiltin<"HLSL_LANG"> {
+ let Spellings = ["__builtin_hlsl_resource_getdimensions_xy"];
+ let Attributes = [NoThrow];
+ let Prototype = "void(__hlsl_resource_t, uint32_t&, uint32_t&)";
+}
+
+def HLSLResourceGetDimensionsLevelsXY : LangBuiltin<"HLSL_LANG"> {
+ let Spellings = ["__builtin_hlsl_resource_getdimensions_levels_xy"];
+ let Attributes = [NoThrow];
+ let Prototype = "void(__hlsl_resource_t, uint32_t, uint32_t&, uint32_t&, uint32_t&)";
+}
+
+def HLSLResourceGetDimensionsXFloat : LangBuiltin<"HLSL_LANG"> {
+ let Spellings = ["__builtin_hlsl_resource_getdimensions_x_float"];
+ let Attributes = [NoThrow];
+ let Prototype = "void(__hlsl_resource_t, float&)";
+}
+
+def HLSLResourceGetDimensionsXYFloat : LangBuiltin<"HLSL_LANG"> {
+ let Spellings = ["__builtin_hlsl_resource_getdimensions_xy_float"];
+ let Attributes = [NoThrow];
+ let Prototype = "void(__hlsl_resource_t, float&, float&)";
+}
+
+def HLSLResourceGetDimensionsLevelsXYFloat : LangBuiltin<"HLSL_LANG"> {
+ let Spellings = ["__builtin_hlsl_resource_getdimensions_levels_xy_float"];
+ let Attributes = [NoThrow];
+ let Prototype = "void(__hlsl_resource_t, uint32_t, float&, float&, float&)";
+}
+
def HLSLResourceGetStride : LangBuiltin<"HLSL_LANG"> {
let Spellings = ["__builtin_hlsl_resource_getstride"];
let Attributes = [NoThrow];
diff --git a/clang/lib/CodeGen/CGHLSLBuiltins.cpp b/clang/lib/CodeGen/CGHLSLBuiltins.cpp
index 71ddbdebf7245..a7d8b0fcd9cb2 100644
--- a/clang/lib/CodeGen/CGHLSLBuiltins.cpp
+++ b/clang/lib/CodeGen/CGHLSLBuiltins.cpp
@@ -882,14 +882,73 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned BuiltinID,
RetTy, CGM.getHLSLRuntime().getNonUniformResourceIndexIntrinsic(),
ArrayRef<Value *>{IndexOp});
}
- case Builtin::BI__builtin_hlsl_resource_getdimensions_x: {
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_x:
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_xy:
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_levels_xy:
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_x_float:
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_xy_float:
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_levels_xy_float: {
Value *Handle = EmitScalarExpr(E->getArg(0));
- LValue Dim = EmitLValue(E->getArg(1));
+ bool HasLod =
+ BuiltinID ==
+ Builtin::BI__builtin_hlsl_resource_getdimensions_levels_xy ||
+ BuiltinID ==
+ Builtin::BI__builtin_hlsl_resource_getdimensions_levels_xy_float;
+ unsigned IntrinsicID;
+ unsigned NumRetComps;
+
+ switch (BuiltinID) {
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_x:
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_x_float:
+ IntrinsicID = CGM.getHLSLRuntime().getGetDimensionsXIntrinsic();
+ NumRetComps = 1;
+ break;
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_xy:
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_xy_float:
+ IntrinsicID = CGM.getHLSLRuntime().getGetDimensionsXYIntrinsic();
+ NumRetComps = 2;
+ break;
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_levels_xy:
+ case Builtin::BI__builtin_hlsl_resource_getdimensions_levels_xy_float:
+ IntrinsicID = CGM.getHLSLRuntime().getGetDimensionsLevelsXYIntrinsic();
+ NumRetComps = 3;
+ break;
+ default:
+ llvm_unreachable("Unknown GetDimensions builtin");
+ }
+
llvm::Type *RetTy = llvm::Type::getInt32Ty(getLLVMContext());
- Value *DimValue = Builder.CreateIntrinsic(
- RetTy, CGM.getHLSLRuntime().getGetDimensionsXIntrinsic(),
- ArrayRef<Value *>{Handle});
- return Builder.CreateStore(DimValue, Dim.getAddress());
+ if (NumRetComps > 1) {
+ RetTy = llvm::FixedVectorType::get(RetTy, NumRetComps);
+ }
+
+ SmallVector<Value *> Args{Handle};
+ if (HasLod) {
+ Args.push_back(EmitScalarExpr(E->getArg(1)));
+ }
+
+ Value *DimValue =
+ Builder.CreateIntrinsic(IntrinsicID, {Handle->getType()}, Args);
+
+ Value *LastStore = nullptr;
+ unsigned ArgIndex = HasLod ? 2 : 1;
+ for (unsigned i = 0; i < NumRetComps; ++i) {
+ LValue DimOut = EmitLValue(E->getArg(ArgIndex++));
+ Value *Elem = DimValue;
+ if (NumRetComps > 1) {
+ Elem = Builder.CreateExtractElement(DimValue, i);
+ }
+
+ // Handle float casting if needed
+ QualType OutTy = E->getArg(ArgIndex - 1)->getType();
+ if (OutTy->isFloatingType()) {
+ Elem = Builder.CreateUIToFP(Elem,
+ llvm::Type::getFloatTy(getLLVMContext()));
+ }
+
+ LastStore = Builder.CreateStore(Elem, DimOut.getAddress());
+ }
+ return LastStore;
}
case Builtin::BI__builtin_hlsl_resource_getstride: {
LValue Stride = EmitLValue(E->getArg(1));
diff --git a/clang/lib/CodeGen/CGHLSLRuntime.h b/clang/lib/CodeGen/CGHLSLRuntime.h
index f473ac13816c0..b1c5b3318a11e 100644
--- a/clang/lib/CodeGen/CGHLSLRuntime.h
+++ b/clang/lib/CodeGen/CGHLSLRuntime.h
@@ -193,6 +193,9 @@ class CGHLSLRuntime {
GENERATE_HLSL_INTRINSIC_FUNCTION(GroupMemoryBarrierWithGroupSync,
group_memory_barrier_with_group_sync)
GENERATE_HLSL_INTRINSIC_FUNCTION(GetDimensionsX, resource_getdimensions_x)
+ GENERATE_HLSL_INTRINSIC_FUNCTION(GetDimensionsXY, resource_getdimensions_xy)
+ GENERATE_HLSL_INTRINSIC_FUNCTION(GetDimensionsLevelsXY,
+ resource_getdimensions_levels_xy)
GENERATE_HLSL_INTRINSIC_FUNCTION(LoadLevel, resource_load_level)
GENERATE_HLSL_INTRINSIC_FUNCTION(CalculateLod, resource_calculate_lod)
GENERATE_HLSL_INTRINSIC_FUNCTION(CalculateLodUnclamped,
diff --git a/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp b/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp
index 0e3b640fa060a..4c8b0283b0f1e 100644
--- a/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp
+++ b/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp
@@ -1885,6 +1885,53 @@ BuiltinTypeDeclBuilder::addSampleCmpLevelZeroMethods(ResourceDimension Dim) {
.finalize();
}
+BuiltinTypeDeclBuilder &
+BuiltinTypeDeclBuilder::addGetDimensionsMethods(ResourceDimension Dim) {
+ assert(!Record->isCompleteDefinition() && "record is already complete");
+ using PH = BuiltinTypeMethodBuilder::PlaceHolder;
+ ASTContext &AST = SemaRef.getASTContext();
+ QualType UIntTy = AST.UnsignedIntTy;
+
+ assert(Dim != ResourceDimension::Unknown);
+
+ QualType FloatTy = AST.FloatTy;
+ // Add overloads for uint and float.
+ QualType Params[] = {UIntTy, FloatTy};
+
+ for (QualType OutTy : Params) {
+ if (Dim == ResourceDimension::Dim2D) {
+ StringRef XYName = "__builtin_hlsl_resource_getdimensions_xy";
+ StringRef LevelsXYName =
+ "__builtin_hlsl_resource_getdimensions_levels_xy";
+
+ if (OutTy == FloatTy) {
+ XYName = "__builtin_hlsl_resource_getdimensions_xy_float";
+ LevelsXYName = "__builtin_hlsl_resource_getdimensions_levels_xy_float";
+ }
+
+ // void GetDimensions(out [uint|float] width, out [uint|float] height)
+ BuiltinTypeMethodBuilder(*this, "GetDimensions", AST.VoidTy)
+ .addParam("width", OutTy, HLSLParamModifierAttr::Keyword_out)
+ .addParam("height", OutTy, HLSLParamModifierAttr::Keyword_out)
+ .callBuiltin(XYName, QualType(), PH::Handle, PH::_0, PH::_1)
+ .finalize();
+
+ // void GetDimensions(uint mipLevel, out [uint|float] width, out
+ // [uint|float] height, out [uint|float] numberOfLevels)
+ BuiltinTypeMethodBuilder(*this, "GetDimensions", AST.VoidTy)
+ .addParam("mipLevel", UIntTy)
+ .addParam("width", OutTy, HLSLParamModifierAttr::Keyword_out)
+ .addParam("height", OutTy, HLSLParamModifierAttr::Keyword_out)
+ .addParam("numberOfLevels", OutTy, HLSLParamModifierAttr::Keyword_out)
+ .callBuiltin(LevelsXYName, QualType(), PH::Handle, PH::_0, PH::_1,
+ PH::_2, PH::_3)
+ .finalize();
+ }
+ }
+
+ return *this;
+}
+
BuiltinTypeDeclBuilder &
BuiltinTypeDeclBuilder::addCalculateLodMethods(ResourceDimension Dim) {
assert(!Record->isCompleteDefinition() && "record is already complete");
diff --git a/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.h b/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.h
index 6f64d751a5811..1ffe5d9a624ef 100644
--- a/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.h
+++ b/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.h
@@ -126,6 +126,7 @@ class BuiltinTypeDeclBuilder {
BuiltinTypeDeclBuilder &addConsumeMethod();
BuiltinTypeDeclBuilder &addGetDimensionsMethodForBuffer();
+ BuiltinTypeDeclBuilder &addGetDimensionsMethods(ResourceDimension Dim);
BuiltinTypeDeclBuilder &addMipsMember(ResourceDimension Dim);
private:
diff --git a/clang/lib/Sema/HLSLExternalSemaSource.cpp b/clang/lib/Sema/HLSLExternalSemaSource.cpp
index 926c3d80e3bd9..235ede8eb0bf0 100644
--- a/clang/lib/Sema/HLSLExternalSemaSource.cpp
+++ b/clang/lib/Sema/HLSLExternalSemaSource.cpp
@@ -272,6 +272,7 @@ static BuiltinTypeDeclBuilder setupTextureType(CXXRecordDecl *Decl, Sema &S,
.addSampleCmpMethods(Dim)
.addSampleCmpLevelZeroMethods(Dim)
.addCalculateLodMethods(Dim)
+ .addGetDimensionsMethods(Dim)
.addGatherMethods(Dim)
.addGatherCmpMethods(Dim);
}
diff --git a/clang/test/AST/HLSL/Texture2D-scalar-AST.hlsl b/clang/test/AST/HLSL/Texture2D-scalar-AST.hlsl
index 10ae411f474b6..f737b3279456b 100644
--- a/clang/test/AST/HLSL/Texture2D-scalar-AST.hlsl
+++ b/clang/test/AST/HLSL/Texture2D-scalar-AST.hlsl
@@ -508,6 +508,88 @@
// CHECK-NEXT: DeclRefExpr {{.*}} 'vector<float, 2>' lvalue ParmVar {{.*}} 'Location' 'vector<float, 2>'
// CHECK-NEXT: AlwaysInlineAttr
+// CHECK: CXXMethodDecl {{.*}} GetDimensions 'void (out unsigned int, out unsigned int)'
+// CHECK-NEXT: ParmVarDecl {{.*}} width 'unsigned int &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: ParmVarDecl {{.*}} height 'unsigned int &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: CompoundStmt
+// CHECK-NEXT: CallExpr {{.*}} '<dependent type>'
+// CHECK-NEXT: DeclRefExpr {{.*}} '<builtin fn type>' Function {{.*}} '__builtin_hlsl_resource_getdimensions_xy' 'void (__hlsl_resource_t, unsigned int &, unsigned int &) noexcept'
+// CHECK-NEXT: MemberExpr {{.*}} '__hlsl_resource_t
+// CHECK-SAME{LITERAL}: [[hlsl::resource_class(SRV)]]
+// CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]]
+// CHECK-SAME{LITERAL}: [[hlsl::resource_dimension(2D)]]
+// CHECK-SAME: ' lvalue .__handle
+// CHECK-NEXT: CXXThisExpr {{.*}} 'hlsl::Texture2D<element_type>' lvalue implicit this
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'width' 'unsigned int &__restrict'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'height' 'unsigned int &__restrict'
+// CHECK-NEXT: AlwaysInlineAttr
+
+// CHECK: CXXMethodDecl {{.*}} GetDimensions 'void (unsigned int, out unsigned int, out unsigned int, out unsigned int)'
+// CHECK-NEXT: ParmVarDecl {{.*}} mipLevel 'unsigned int'
+// CHECK-NEXT: ParmVarDecl {{.*}} width 'unsigned int &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: ParmVarDecl {{.*}} height 'unsigned int &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: ParmVarDecl {{.*}} numberOfLevels 'unsigned int &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: CompoundStmt
+// CHECK-NEXT: CallExpr {{.*}} '<dependent type>'
+// CHECK-NEXT: DeclRefExpr {{.*}} '<builtin fn type>' Function {{.*}} '__builtin_hlsl_resource_getdimensions_levels_xy' 'void (__hlsl_resource_t, unsigned int, unsigned int &, unsigned int &, unsigned int &) noexcept'
+// CHECK-NEXT: MemberExpr {{.*}} '__hlsl_resource_t
+// CHECK-SAME{LITERAL}: [[hlsl::resource_class(SRV)]]
+// CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]]
+// CHECK-SAME{LITERAL}: [[hlsl::resource_dimension(2D)]]
+// CHECK-SAME: ' lvalue .__handle
+// CHECK-NEXT: CXXThisExpr {{.*}} 'hlsl::Texture2D<element_type>' lvalue implicit this
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'mipLevel' 'unsigned int'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'width' 'unsigned int &__restrict'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'height' 'unsigned int &__restrict'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'numberOfLevels' 'unsigned int &__restrict'
+// CHECK-NEXT: AlwaysInlineAttr
+
+// CHECK: CXXMethodDecl {{.*}} GetDimensions 'void (out float, out float)'
+// CHECK-NEXT: ParmVarDecl {{.*}} width 'float &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: ParmVarDecl {{.*}} height 'float &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: CompoundStmt
+// CHECK-NEXT: CallExpr {{.*}} '<dependent type>'
+// CHECK-NEXT: DeclRefExpr {{.*}} '<builtin fn type>' Function {{.*}} '__builtin_hlsl_resource_getdimensions_xy_float' 'void (__hlsl_resource_t, float &, float &) noexcept'
+// CHECK-NEXT: MemberExpr {{.*}} '__hlsl_resource_t
+// CHECK-SAME{LITERAL}: [[hlsl::resource_class(SRV)]]
+// CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]]
+// CHECK-SAME{LITERAL}: [[hlsl::resource_dimension(2D)]]
+// CHECK-SAME: ' lvalue .__handle
+// CHECK-NEXT: CXXThisExpr {{.*}} 'hlsl::Texture2D<element_type>' lvalue implicit this
+// CHECK-NEXT: DeclRefExpr {{.*}} 'float' lvalue ParmVar {{.*}} 'width' 'float &__restrict'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'float' lvalue ParmVar {{.*}} 'height' 'float &__restrict'
+// CHECK-NEXT: AlwaysInlineAttr
+
+// CHECK: CXXMethodDecl {{.*}} GetDimensions 'void (unsigned int, out float, out float, out float)'
+// CHECK-NEXT: ParmVarDecl {{.*}} mipLevel 'unsigned int'
+// CHECK-NEXT: ParmVarDecl {{.*}} width 'float &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: ParmVarDecl {{.*}} height 'float &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: ParmVarDecl {{.*}} numberOfLevels 'float &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: CompoundStmt
+// CHECK-NEXT: CallExpr {{.*}} '<dependent type>'
+// CHECK-NEXT: DeclRefExpr {{.*}} '<builtin fn type>' Function {{.*}} '__builtin_hlsl_resource_getdimensions_levels_xy_float' 'void (__hlsl_resource_t, unsigned int, float &, float &, float &) noexcept'
+// CHECK-NEXT: MemberExpr {{.*}} '__hlsl_resource_t
+// CHECK-SAME{LITERAL}: [[hlsl::resource_class(SRV)]]
+// CHECK-SAME{LITERAL}: [[hlsl::contained_type(element_type)]]
+// CHECK-SAME{LITERAL}: [[hlsl::resource_dimension(2D)]]
+// CHECK-SAME: ' lvalue .__handle
+// CHECK-NEXT: CXXThisExpr {{.*}} 'hlsl::Texture2D<element_type>' lvalue implicit this
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'mipLevel' 'unsigned int'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'float' lvalue ParmVar {{.*}} 'width' 'float &__restrict'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'float' lvalue ParmVar {{.*}} 'height' 'float &__restrict'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'float' lvalue ParmVar {{.*}} 'numberOfLevels' 'float &__restrict'
+// CHECK-NEXT: AlwaysInlineAttr
+
// CHECK: CXXMethodDecl {{.*}} Gather 'vector<element_type, 4> (hlsl::SamplerState, vector<float, 2>)' inline
// CHECK-NEXT: ParmVarDecl {{.*}} Sampler 'hlsl::SamplerState'
// CHECK-NEXT: ParmVarDecl {{.*}} Location 'vector<float, 2>'
@@ -814,4 +896,10 @@ void main(float2 loc, float cmp) {
t.CalculateLevelOfDetail(s, loc);
t.CalculateLevelOfDetailUnclamped(s, loc);
t.Gather(s, loc);
+ uint u_w, u_h, u_l;
+ float f_w, f_h, f_l;
+ t.GetDimensions(u_w, u_h);
+ t.GetDimensions(0, u_w, u_h, u_l);
+ t.GetDimensions(f_w, f_h);
+ t.GetDimensions(0, f_w, f_h, f_l);
}
diff --git a/clang/test/AST/HLSL/Texture2D-vector-AST.hlsl b/clang/test/AST/HLSL/Texture2D-vector-AST.hlsl
index 36b569def89e1..5cd8976f5de8d 100644
--- a/clang/test/AST/HLSL/Texture2D-vector-AST.hlsl
+++ b/clang/test/AST/HLSL/Texture2D-vector-AST.hlsl
@@ -512,6 +512,84 @@
// CHECK-NEXT: DeclRefExpr {{.*}} 'vector<float, 2>' lvalue ParmVar {{.*}} 'Location' 'vector<float, 2>'
// CHECK-NEXT: AlwaysInlineAttr
+// CHECK: CXXMethodDecl {{.*}} GetDimensions 'void (out unsigned int, out unsigned int)'
+// CHECK-NEXT: ParmVarDecl {{.*}} width 'unsigned int &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: ParmVarDecl {{.*}} height 'unsigned int &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: CompoundStmt
+// CHECK-NEXT: CallExpr {{.*}}
+// CHECK-NEXT: DeclRefExpr {{.*}} '__builtin_hlsl_resource_getdimensions_xy' 'void (__hlsl_resource_t, unsigned int &, unsigned int &) noexcept'
+// CHECK-NEXT: MemberExpr {{.*}} '__hlsl_resource_t
+// CHECK-SAME{LITERAL}: [[hlsl::resource_class(SRV)]]
+// CHECK-SAME{LITERAL}: [[hlsl::contained_type(vector<element_type, element_count>)]]
+// CHECK-SAME{LITERAL}: [[hlsl::resource_dimension(2D)]]
+// CHECK-SAME: ' lvalue .__handle
+// CHECK-NEXT: CXXThisExpr {{.*}} 'hlsl::Texture2D<vector<element_type, element_count>>' lvalue implicit this
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'width' 'unsigned int &__restrict'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'height' 'unsigned int &__restrict'
+
+// CHECK: CXXMethodDecl {{.*}} GetDimensions 'void (unsigned int, out unsigned int, out unsigned int, out unsigned int)'
+// CHECK-NEXT: ParmVarDecl {{.*}} mipLevel 'unsigned int'
+// CHECK-NEXT: ParmVarDecl {{.*}} width 'unsigned int &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: ParmVarDecl {{.*}} height 'unsigned int &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: ParmVarDecl {{.*}} numberOfLevels 'unsigned int &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: CompoundStmt
+// CHECK-NEXT: CallExpr {{.*}}
+// CHECK-NEXT: DeclRefExpr {{.*}} '__builtin_hlsl_resource_getdimensions_levels_xy' 'void (__hlsl_resource_t, unsigned int, unsigned int &, unsigned int &, unsigned int &) noexcept'
+// CHECK-NEXT: MemberExpr {{.*}} '__hlsl_resource_t
+// CHECK-SAME{LITERAL}: [[hlsl::resource_class(SRV)]]
+// CHECK-SAME{LITERAL}: [[hlsl::contained_type(vector<element_type, element_count>)]]
+// CHECK-SAME{LITERAL}: [[hlsl::resource_dimension(2D)]]
+// CHECK-SAME: ' lvalue .__handle
+// CHECK-NEXT: CXXThisExpr {{.*}} 'hlsl::Texture2D<vector<element_type, element_count>>' lvalue implicit this
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'mipLevel' 'unsigned int'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'width' 'unsigned int &__restrict'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'height' 'unsigned int &__restrict'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'unsigned int' lvalue ParmVar {{.*}} 'numberOfLevels' 'unsigned int &__restrict'
+
+// CHECK: CXXMethodDecl {{.*}} GetDimensions 'void (out float, out float)'
+// CHECK-NEXT: ParmVarDecl {{.*}} width 'float &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: ParmVarDecl {{.*}} height 'float &__restrict'
+// CHECK-NEXT: HLSLParamModifierAttr {{.*}} out
+// CHECK-NEXT: CompoundStmt
+// CHECK-NEXT: CallExpr {{.*}}
+// CHECK-NEXT: DeclRefExpr {{.*}} '__builtin_hlsl_resource_getdimensions_xy_float' 'void (__hlsl_resource_t, float &, float &) noexcept'
+// CHECK-NEXT: MemberExpr {{.*}} '__hlsl_resource_t
+// CHECK-SAME{LITERAL}: [[hlsl::resource_class(SRV)]]
+// CHECK-SAME{LITERAL}: [[hlsl::contained_type(vector<element_type, element_count>)]]
+// CHECK-SAME{LITERAL}: [[hlsl::resource_dimension(2D)]]
+// CHECK-SAME: ' lvalue .__handle
+// CHECK-NEXT: CXXThisExpr {{.*}} 'hlsl::Texture2D<vector<element_type, element_count>>' lvalue implicit this
+// CHECK-NEXT: DeclRefExpr {{.*}} 'float' lvalue ParmVar {{.*}} 'width' 'float &__restrict'
+// CHECK-NEXT: DeclRefExpr {{.*}} 'float' lvalu...
[truncated]
``````````
</details>
https://github.com/llvm/llvm-project/pull/189991
More information about the llvm-branch-commits
mailing list