[llvm-branch-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [mlir] [openmp] release/21.x: [CMake][AIX] quote the string AIX `if` conditions (PR #156505)
Tobias Hieta via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Mon Sep 29 01:41:52 PDT 2025
tru wrote:
I still feel pretty sketchy about this one. It seems large and could affect other platforms than AIX since it's changing the build system in pretty large ways.
I would be much more comfortable if we just drop this for the release branch and make sure it's working well in `main` before the next release. The main problem I have here is that there is also no maintainer for the CMake scripts in whole, I guess maybe @petrhosek would be the closest.
I understand it could be a bit of a pain for the AIX packages - but I wonder if it's not worth a little pain for a platform that ... frankly isn't that mainstream in order to avoid any potential issues with other platforms. I understand that it's not a blocker really, just annoying so that gives me more confidence to reject this.
https://github.com/llvm/llvm-project/pull/156505
More information about the llvm-branch-commits
mailing list