[llvm-branch-commits] [llvm] [Remarks] Restructure bitstream remarks to be fully standalone (PR #156715)

[Florian Hahn via llvm-branch-commits]

================
@@ -263,45 +301,52 @@ remarks::createBitstreamParserFromMeta(
   return std::move(Parser);
 }
 
+BitstreamRemarkParser::BitstreamRemarkParser(StringRef Buf)
+    : RemarkParser(Format::Bitstream), ParserHelper(Buf) {}
+
 Expected<std::unique_ptr<Remark>> BitstreamRemarkParser::next() {
-  if (ParserHelper.atEndOfStream())
-    return make_error<EndOfFileError>();
+  if (!IsMetaReady) {
+    // Container is completely empty
+    if (ParserHelper->Stream.AtEndOfStream())
+      return make_error<EndOfFileError>();
 
-  if (!ReadyToParseRemarks) {
     if (Error E = parseMeta())
       return std::move(E);
-    ReadyToParseRemarks = true;
+    IsMetaReady = true;
+
+    // Container has meta, but no remarks blocks
----------------
fhahn wrote:

```suggestion
    // Container has meta, but no remarks blocks.
```


https://github.com/llvm/llvm-project/pull/156715