[llvm-branch-commits] [llvm] [mlir] [flang][OpenMP] Support multi-block reduction combiner regions on the GPU (PR #156837)

Kareem Ergawy via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Sep 16 05:44:20 PDT 2025


ergawy wrote:

> Thanks for handling my comments. It looks good to me but I have one question. This patch sets the insertion point so that store instruction gets generated at the correct place. But the test does not check for any store instruction. I was just wondering if the test is checking the right thing.

Without the changes in the PR, the test crashes flang. However, I agree that the test should be expanded a bit. Added more checks to capture better the code-gen of the reduction.

https://github.com/llvm/llvm-project/pull/156837


More information about the llvm-branch-commits mailing list