[llvm-branch-commits] [llvm] [AllocToken, Clang] Implement __builtin_alloc_token_infer() and llvm.alloc.token.id (PR #156842)

[Oliver Hunt via llvm-branch-commits]

================
@@ -5760,6 +5764,24 @@ bool Sema::BuiltinAllocaWithAlign(CallExpr *TheCall) {
   return false;
 }
 
+bool Sema::BuiltinAllocTokenInfer(CallExpr *TheCall) {
----------------
ojhunt wrote:

I would prefer this not be a Sema member, and would prefer the static function with a `Sema&` parameter model instead? I find the `Sema::Builtin*(..)` naming model to be unnecessarily noisy and confusing, and as it looks like there's a mix of `Sema::` methods  and `static` functions, I wonder if there's a strong preference among others?

cc @Endilll, and @AaronBallman (who I believe is on vacation or similar so I would expect/hope not to get an immediate reply) 



https://github.com/llvm/llvm-project/pull/156842