[llvm-branch-commits] [not] Update disable-symbolization.test to work with internal shell (PR #157236)

Aiden Grossman via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Sep 8 10:39:13 PDT 2025


boomanaiden154 wrote:

> Should we update the lit implementation handling for not/env to avoid reordering those two commands when combined?

We theoretically can, but it's not that simple. The test runner already explicitly reorders them due to how `not` needs to be run. I'm not sure of exact test cases where the following is relevant, but it seems like it would be difficult to tease apart, and was not worth it for this test based on my assessment:

https://github.com/llvm/llvm-project/blob/d2646cac857294604afaae67f165323b0af35430/llvm/utils/lit/lit/TestRunner.py#L851

https://github.com/llvm/llvm-project/pull/157236


More information about the llvm-branch-commits mailing list