[llvm-branch-commits] [MC] Invoke run line in stdin.s using bash (PR #157232)

Aiden Grossman via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sun Sep 7 10:13:26 PDT 2025


boomanaiden154 wrote:

> I don't know if I understand what you're going for in this patch. How is this an improvement over just keeping REQUIRES: shell? The REQUIRES:  bit is what's going to stop the test from running in the wrong environment. That seems like the right tradeoff.

If we don't get rid of all the `REQUIRES: shell` checks and we want to turn on the internal shell by default, we end up losing test coverage here. Unless we explicitly have a buildbot running tests with the exteral shell, which seems like a bit of a waste.

Let me try rewriting this one in Python though, because I think that will capture the semantics of the test better and also avoid the use of bash.

https://github.com/llvm/llvm-project/pull/157232


More information about the llvm-branch-commits mailing list