[llvm-branch-commits] [ADT][NFC] Add missing #include <vector> (#165068) (PR #165074)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Fri Oct 24 22:06:26 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-adt
Author: Vitaly Buka (vitalybuka)
<details>
<summary>Changes</summary>
Added in #<!-- -->164524. Fails when using libc++ in a mode that prunes
transitive headers.
---
Full diff: https://github.com/llvm/llvm-project/pull/165074.diff
2 Files Affected:
- (modified) llvm/include/llvm/ADT/RadixTree.h (+1)
- (modified) llvm/lib/Support/SpecialCaseList.cpp (+5-5)
``````````diff
diff --git a/llvm/include/llvm/ADT/RadixTree.h b/llvm/include/llvm/ADT/RadixTree.h
index d3c44e4e6345c..a65acddf186b7 100644
--- a/llvm/include/llvm/ADT/RadixTree.h
+++ b/llvm/include/llvm/ADT/RadixTree.h
@@ -22,6 +22,7 @@
#include <limits>
#include <list>
#include <utility>
+#include <vector>
namespace llvm {
diff --git a/llvm/lib/Support/SpecialCaseList.cpp b/llvm/lib/Support/SpecialCaseList.cpp
index 944f59f245be3..1e303ebbfd3f2 100644
--- a/llvm/lib/Support/SpecialCaseList.cpp
+++ b/llvm/lib/Support/SpecialCaseList.cpp
@@ -121,13 +121,13 @@ void SpecialCaseList::GlobMatcher::match(
SuffixPrefixToGlob.find_prefixes(reverse(Query))) {
for (const auto &[_, V] : PToGlob.find_prefixes(Query)) {
for (const auto *G : V) {
- // Each value of the map is a vector of globs sorted as from best to
- // worst.
+ // Each value of the map is a vector of globs ordered from the best to
+ // the worst.
if (G->Pattern.match(Query)) {
Cb(G->Name, G->LineNo);
- // As soon as we find a match in the vector we can break for the vector,
- // vector, but we still need to continue for other values in the
- // map, as they may contain a better match.
+ // As soon as we find a match in the vector we can break for the
+ // vector, still we can't return, and need to continue for others
+ // values in the map, as they may contain a better match.
break;
}
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/165074
More information about the llvm-branch-commits
mailing list