[llvm-branch-commits] [clang] [Clang][CodeGen] Implement code generation for __builtin_infer_alloc_token() (PR #156842)

[Oliver Hunt via llvm-branch-commits]

ojhunt wrote:

Ok, so one thing I see in the tests is a similar issue to what I've been looking at while prepping the tmo feature - the tests are essentially "random looking number". We've had regressions in the past as a result of the tests being essentially opaque - I'm unsure if it's worth you addressing this here as I'll be looking to address it while upstreaming the tmo functionality in which case we're just duplicating effort.

One thing that seems weird to me is that you're emitting an llvm runtime call to alloc_token_id - I've been dealing with ptrauth for long enough for brain overflow (and I do have real memory problems :-/) so I'm sorry if I've forgotten the rationale, but my expectation was that this should be producing a constant token (it needs to be const evaluable for templates, etc).

I also realized my original dream (return the pseudo type) doesn't work because C would have no wait to understand it, and C++ would have only marginally less difficulty.

https://github.com/llvm/llvm-project/pull/156842