[llvm-branch-commits] [clang] [CIR] Upstream `AddressSpace` conversions support (PR #161212)

[David Rivera via llvm-branch-commits]

RiverDave wrote:

I updated this based on the recent feedback on #161028 

I made a change tn the function: `performAddrSpaceCast` and I opted for getting rid of the `LangAS` parameters for both source and destination, there’s to main reasons:

1. They were redundant and not utilized.
2. In [OG](https://github.com/llvm/llvm-project/blob/487cdf14f67e95f61a42389bd168b32c00995ea4/clang/lib/CodeGen/TargetInfo.cpp#L149) they seem to be used to name SSA values in casts? I do not think that applies to CIR/MLIR in any way (correct me if I’m wrong)
3. This change made not long ago: https://github.com/llvm/llvm-project/pull/138866 => this applies only to dest, however as I previously mentioned, I don't see the point in replicating OG in that regard.

https://github.com/llvm/llvm-project/pull/161212