[llvm-branch-commits] [llvm] Add IR and codegen support for deactivation symbols. (PR #133536)
Peter Collingbourne via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Tue Nov 25 22:18:52 PST 2025
================
@@ -1250,7 +1262,8 @@ EmitSpecialNode(SDNode *Node, bool IsClone, bool IsCloned,
llvm_unreachable("This target-independent node should have been selected!");
case ISD::EntryToken:
case ISD::MERGE_VALUES:
- case ISD::TokenFactor: // fall thru
+ case ISD::TokenFactor:
+ case ISD::DEACTIVATION_SYMBOL:
----------------
pcc wrote:
The comment was not accurate because of the break. Well, I guess it could also mean that the cases above all fall through, but I think most people already understand that and it doesn't need to be commented about. I also found this comment a bit confusing given the break (maybe there's somehow something special about the break that means that it actually falls through?) so I think it's best to delete it.
https://github.com/llvm/llvm-project/pull/133536
More information about the llvm-branch-commits
mailing list