[llvm-branch-commits] [llvm] [BOLT][BTI] Add MCPlusBuilder::addBTItoBBStart (PR #167329)

[Peter Waller via llvm-branch-commits]

================
@@ -1888,6 +1888,19 @@ class MCPlusBuilder {
     llvm_unreachable("not implemented");
   }
 
+  /// Checks if the indirect call / jump is accepted by the landing pad at the
+  /// start of the target BasicBlock.
+  virtual bool isBTIVariantCoveringCall(MCInst &Call, MCInst &Pad) const {
+    llvm_unreachable("not implemented");
+    return false;
+  }
+
+  /// Adds a BTI landing pad to the start of the BB, that matches the indirect
+  /// call/jump inst.
+  virtual void addBTItoBBStart(BinaryBasicBlock &BB, MCInst &Call) const {
----------------
peterwaller-arm wrote:

Nit: should it be addBTIToBBStart?

If we're entertaining a rename, how about `insert` rather than add - since normally I think of putting something at the beginning of a list as 'insertion' rather than 'addition'. `insertBTI` would be a clear verb for a function name (and 'ToBBStart would be a bit redundant since presumably we won't expect to insert a BTI anywhere else?)

https://github.com/llvm/llvm-project/pull/167329