[llvm-branch-commits] [llvm] [SPIRV][SPIRVPrepareGlobals] Map AMD's dynamic LDS 0-element globals to arrays with UINT32_MAX elements (PR #166952)

[Steven Perron via llvm-branch-commits]

Juan Manuel Martinez =?utf-8?q?Caamaño?=,
Juan Manuel Martinez =?utf-8?q?Caamaño?=,
Juan Manuel Martinez =?utf-8?q?Caamaño?Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/166952 at github.com>


s-perron wrote:

> > I'm wondering if you need to change all 0-sized array or not. If so, we might want to centralize the conversion of 0-sized arrays. We could try to move the code that changes them to 1 element arrays here as well.
> 
> If you point me to where this is happening I can try to do that too as a follow-up patch.

I was wrong. I was thinking for https://github.com/llvm/llvm-project/pull/149522, but that does not changes the global variables, it just change the type on the GEP. They seem different enough that they may not be reasonable to merge into a single place.

https://github.com/llvm/llvm-project/pull/166952