[llvm-branch-commits] [llvm] [SPIRV][SPIRVPrepareGlobals] Map AMD's dynamic LDS 0-element globals to arrays with UINT32_MAX elements (PR #166952)

[Steven Perron via llvm-branch-commits]

Juan Manuel Martinez =?utf-8?q?Caamaño?Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/166952 at github.com>


================
@@ -43,6 +44,29 @@ bool tryExtendLLVMBitcodeMarker(GlobalVariable &Bitcode) {
   return true;
 }
 
+bool tryExtendDynamicLDSGlobal(GlobalVariable &GV) {
+  constexpr unsigned WorkgroupAS = 3;
----------------
s-perron wrote:

It is very unlinkely that this will change, but could this be changed to used named constants:

```suggestion
  constexpr unsigned WorkgroupAS = storageClassToAddressSpace(SPIRV::StorageClass::Workgroup);
```

It should all get folded at compile time since it is all constexpr.

https://github.com/llvm/llvm-project/pull/166952