[llvm-branch-commits] [llvm] [BOLT] Gadget scanner: detect authentication oracles (PR #135663)

[Kristof Beyls via llvm-branch-commits]

================
@@ -717,6 +716,466 @@ SrcSafetyAnalysis::create(BinaryFunction &BF,
                                                        RegsToTrackInstsFor);
 }
 
+/// A state representing which registers are safe to be used as the destination
+/// operand of an authentication instruction.
+///
+/// Similar to SrcState, it is the analysis that should take register aliasing
+/// into account.
+///
----------------
kbeyls wrote:

At first sight, it looks like there is quite a bit of code added here for `DstState` and `DstSafetyAnalysis`. I wonder if you have thought about/analyzed if it would be (a) possible and (b) desirable to try and share more of the implementation between the `Dst...` and `Src...` classes?
I haven't investigated this at all --- just thought I'd ask you first in case you had thought about this before.

https://github.com/llvm/llvm-project/pull/135663