[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add parsing of floats for StaticSampler (PR #140181)
Finn Plummer via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Fri May 16 09:16:01 PDT 2025
================
@@ -663,6 +669,23 @@ RootSignatureParser::parseStaticSamplerParams() {
return std::nullopt;
Params.Reg = Reg;
}
+
+ // `mipLODBias` `=` NUMBER
+ if (tryConsumeExpectedToken(TokenKind::kw_mipLODBias)) {
+ if (Params.MipLODBias.has_value()) {
+ getDiags().Report(CurToken.TokLoc, diag::err_hlsl_rootsig_repeat_param)
+ << CurToken.TokKind;
+ return std::nullopt;
+ }
+
+ if (consumeExpectedToken(TokenKind::pu_equal))
+ return std::nullopt;
+
+ auto MipLODBias = parseFloatParam();
+ if (!MipLODBias.has_value())
+ return std::nullopt;
+ Params.MipLODBias = (float)*MipLODBias;
----------------
inbelic wrote:
```suggestion
Params.MipLODBias = MipLODBias;
```
can remove lingering cast from previous version
https://github.com/llvm/llvm-project/pull/140181
More information about the llvm-branch-commits
mailing list