[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add mandatory parameters for RootConstants (PR #138002)

Ashley Coleman via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu May 8 14:26:01 PDT 2025


================
@@ -57,6 +57,27 @@ std::optional<RootConstants> RootSignatureParser::parseRootConstants() {
 
   RootConstants Constants;
 
+  auto Params = parseRootConstantParams();
+  if (!Params.has_value())
+    return std::nullopt;
+
+  // Check mandatory parameters were provided
----------------
V-FEXrt wrote:

```suggestion
  // Check mandatory parameters where provided
```

https://github.com/llvm/llvm-project/pull/138002


More information about the llvm-branch-commits mailing list