[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] cancel(lation point) taskgroup LLVMIR (PR #137841)

Sergio Afonso via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed May 7 06:06:24 PDT 2025


================
@@ -3075,9 +3115,6 @@ convertOmpCancel(omp::CancelOp op, llvm::IRBuilderBase &builder,
   llvm::OpenMPIRBuilder::LocationDescription ompLoc(builder);
   llvm::OpenMPIRBuilder *ompBuilder = moduleTranslation.getOpenMPBuilder();
 
-  if (failed(checkImplementationStatus(*op.getOperation())))
-    return failure();
-
----------------
skatrak wrote:

Nit: Even if all clauses for the operation are already supported, I think we should still call `checkImplementationStatus()`. It succeeds by default for operations that don't have explicit checks, and it makes adding new checks whenever unsupported operands are introduced easier later on.

https://github.com/llvm/llvm-project/pull/137841


More information about the llvm-branch-commits mailing list