[llvm-branch-commits] [libcxx] release/20.x: [libcxx] Provide locale conversions to tests through lit substitution (#105651) (PR #136449)

Martin Storsjö via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon May 5 13:56:23 PDT 2025


mstorsjo wrote:

> @mstorsjo Is there a reason to want to backport this, since this is only fixing the test suite? I wouldn't oppose it, but it looks like this needs work to pass CI on the release branch and I'm not sure it's worth the trouble.

Yeah it's not a high value fix in itself, but being able to successfully run the libcxx tests in more environments can be valuable.

I hadn't noticed that the failures were real and actually caused by the backport. I'll see if I can look into that and how complicated the fix would be - I agree that it might not be worth it if the fix is complicated.


https://github.com/llvm/llvm-project/pull/136449


More information about the llvm-branch-commits mailing list