[llvm-branch-commits] [llvm] 3593789 - Revert "[MC] Explicitly mark MCSymbol for MO_ExternalSymbol (#108880)"

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Mar 27 11:12:55 PDT 2025


Author: Eli Friedman
Date: 2025-03-27T11:12:51-07:00
New Revision: 35937892be532c8bd5fda5b738141cab1b347f81

URL: https://github.com/llvm/llvm-project/commit/35937892be532c8bd5fda5b738141cab1b347f81
DIFF: https://github.com/llvm/llvm-project/commit/35937892be532c8bd5fda5b738141cab1b347f81.diff

LOG: Revert "[MC] Explicitly mark MCSymbol for MO_ExternalSymbol (#108880)"

This reverts commit 3d0846bedcd18d546fd3733c93c2e144f2faab09.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86MCInstLower.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86MCInstLower.cpp b/llvm/lib/Target/X86/X86MCInstLower.cpp
index 3bd012c13cf0d..3f6cd55618666 100644
--- a/llvm/lib/Target/X86/X86MCInstLower.cpp
+++ b/llvm/lib/Target/X86/X86MCInstLower.cpp
@@ -349,12 +349,8 @@ MCOperand X86MCInstLower::LowerMachineOperand(const MachineInstr *MI,
     return MCOperand::createImm(MO.getImm());
   case MachineOperand::MO_MachineBasicBlock:
   case MachineOperand::MO_GlobalAddress:
+  case MachineOperand::MO_ExternalSymbol:
     return LowerSymbolOperand(MO, GetSymbolFromOperand(MO));
-  case MachineOperand::MO_ExternalSymbol: {
-    MCSymbol *Sym = GetSymbolFromOperand(MO);
-    Sym->setExternal(true);
-    return LowerSymbolOperand(MO, Sym);
-  }
   case MachineOperand::MO_MCSymbol:
     return LowerSymbolOperand(MO, MO.getMCSymbol());
   case MachineOperand::MO_JumpTableIndex:


        


More information about the llvm-branch-commits mailing list