[llvm-branch-commits] [llvm] [BOLT] Gadget scanner: detect non-protected indirect calls (PR #131899)

[Kristof Beyls via llvm-branch-commits]

================
@@ -0,0 +1,676 @@
+// RUN: %clang %cflags -march=armv8.3-a %s -o %t.exe
+// RUN: llvm-bolt-binary-analysis --scanners=pacret %t.exe 2>&1 | FileCheck %s
+
+// FIXME In the below test cases, LR is usually not spilled as needed, as it is
+//       not checked by BOLT.
----------------
kbeyls wrote:

I'm wondering if this needs to be a FIXME, or simply a note to explain that the test cases are simplified/artificial?
I don't think I've got a strong opinion either way. Presumably, it'd be better for the test cases to be closer to "real-world" code, so ideally, they should have the ldp/stp spill/fill instructions?

https://github.com/llvm/llvm-project/pull/131899