[llvm-branch-commits] [llvm] [AMDGPU][SDAG] Handle ISD::PTRADD in various special cases (PR #145330)

Matt Arsenault via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Jun 27 01:16:29 PDT 2025


================
@@ -2230,7 +2230,7 @@ bool AMDGPUDAGToDAGISel::SelectSMRDBaseOffset(SDValue Addr, SDValue &SBase,
 
   SDValue N0, N1;
   // Extract the base and offset if possible.
-  if (CurDAG->isBaseWithConstantOffset(Addr) || Addr.getOpcode() == ISD::ADD) {
+  if (CurDAG->isBaseWithConstantOffset(Addr) || Addr->isAnyAdd()) {
----------------
arsenm wrote:

The existing code doesn't make sense to me, why is this checking isBaseWithConstantOffset if it isn't parsing out the constant offset? This is just redundant with the isAnyAdd?

https://github.com/llvm/llvm-project/pull/145330


More information about the llvm-branch-commits mailing list