[llvm-branch-commits] [llvm] ARM: Avoid using isTarget wrappers around Triple predicates (PR #144705)

Peter Smith via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Jun 18 09:16:51 PDT 2025


https://github.com/smithp35 commented:

This looks reasonable to me. I can't see a way of changing those properties on a subtarget level with attributes. 

Added the ARM backend maintainers to see if they have anything to add.

Would it be worth adding a comment to the function definitions in Subtarget https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/ARM/ARMSubtarget.h#L336

Something similar to the comment about the isCortexA5() in https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/ARM/ARMSubtarget.h#L285 
```
/// These properties are per-module, please use the TargetMachine TargetTriple.
```

https://github.com/llvm/llvm-project/pull/144705


More information about the llvm-branch-commits mailing list