[llvm-branch-commits] [mlir] [MLIR] Fix incorrect slice contiguity inference in `vector::isContiguousSlice` (PR #142422)

[Momchil Velikov via llvm-branch-commits]

================
@@ -630,7 +639,10 @@ class FlattenContiguousRowMajorTransferReadPattern
     if (transferReadOp.getMask())
       return failure();
 
-    int64_t firstDimToCollapse = sourceType.getRank() - vectorType.getRank();
----------------
momchil-velikov wrote:

> > I've chosen to do maximum collapsing, as it seems simpler to do, and the resulting IR is arguably simpler.

> Ok. Maybe it is simpler in these 2 senses. I guess minimising change (compared to pre-PR and to pre-pass) could be another metric.

On a second thought, perhaps _minimum_ collapsing would be more appropriate, since it discards less information.

https://github.com/llvm/llvm-project/pull/142422