[llvm-branch-commits] [libcxx] [libcxx] Include __fwd/span.h in <mdspan> (PR #142925)

Aiden Grossman via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sat Jun 7 13:06:33 PDT 2025


https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/142925

>From 357a155d005c20fc10206d046c9b7c010626d9e3 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Thu, 5 Jun 2025 08:42:55 +0000
Subject: [PATCH 1/2] formatting

Created using spr 1.3.4
---
 libcxx/include/mdspan | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/include/mdspan b/libcxx/include/mdspan
index 06d2fb6fcd026..32468a128dc9a 100644
--- a/libcxx/include/mdspan
+++ b/libcxx/include/mdspan
@@ -450,8 +450,8 @@ namespace std {
 #  include <__config>
 
 #  if _LIBCPP_STD_VER >= 23
-#    include <__fwd/span.h>
 #    include <__fwd/mdspan.h>
+#    include <__fwd/span.h>
 #    include <__mdspan/default_accessor.h>
 #    include <__mdspan/extents.h>
 #    include <__mdspan/layout_left.h>

>From 835d16aff1f067939bd458ac606a2d373b243ef6 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Sat, 7 Jun 2025 13:06:25 -0700
Subject: [PATCH 2/2] feedback

Created using spr 1.3.6
---
 libcxx/include/mdspan | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/libcxx/include/mdspan b/libcxx/include/mdspan
index 32468a128dc9a..5aeec1bcbfc39 100644
--- a/libcxx/include/mdspan
+++ b/libcxx/include/mdspan
@@ -450,7 +450,11 @@ namespace std {
 #  include <__config>
 
 #  if _LIBCPP_STD_VER >= 23
-#    include <__fwd/mdspan.h>
+#    include <__fwd/mdspan.h> // TODO(boomanaiden154): This is currently a
+                              // non-standard extension to include
+                              // std::dynamic_extent tracked by LWG issue 4275.
+                              // This comment should be deleted or the include
+                              // deleted upon resolution.
 #    include <__fwd/span.h>
 #    include <__mdspan/default_accessor.h>
 #    include <__mdspan/extents.h>



More information about the llvm-branch-commits mailing list