[llvm-branch-commits] [mlir] [MLIR] Fix incorrect slice contiguity inference in `vector::isContiguousSlice` (PR #142422)

James Newling via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Jun 5 12:10:58 PDT 2025


================
@@ -582,6 +582,15 @@ static SmallVector<Value> getCollapsedIndices(RewriterBase &rewriter,
 
 namespace {
 
+/// Helper functon to return the index of the last dynamic dimension in `shape`.
----------------
newling wrote:

```suggestion
/// Helper functon to return the index of the last dynamic dimension in `shape`. or -1 if there are no dynamic dimensions
```
... if I understand correctly, although it might be static_cast<int64_t>(0ULL - 1), not sure what that is

https://github.com/llvm/llvm-project/pull/142422


More information about the llvm-branch-commits mailing list