[llvm-branch-commits] [mlir] [mlir][linalg] Enable scalable vectorization of linalg.unpack (PR #149293)

[Andrzej Warzyński via llvm-branch-commits]

================
@@ -2487,12 +2531,14 @@ vectorizeScalableVectorPrecondition(Operation *op,
   if (numOfScalableDims == 0)
     return success();
 
+  // TODO: Check the following!
----------------
banach-space wrote:

Let me remove this. It was meant as a reminder for myself to double check this. 

Basically, `LinalgOp` means [LinalgStructuredInterface](https://github.com/llvm/llvm-project/blob/85349b49364d240a2e82981a7d7e0d01b13b1284/mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td#L227-L230), which is something that `linalg.unpack` does not implement, see the definition of [Linalg_RelayoutOp](https://github.com/llvm/llvm-project/blob/85349b49364d240a2e82981a7d7e0d01b13b1284/mlir/include/mlir/Dialect/Linalg/IR/LinalgRelayoutOps.td#L33-L41).

Hopefully the comment below is sufficient here. Reverted the TODO in [this commit](https://github.com/llvm/llvm-project/pull/149293/commits/d213e161eecc83284fab3916b0258a4a24e4a614)

https://github.com/llvm/llvm-project/pull/149293