[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Retain `SourceLocation` of `RootElement` for `SemaHLSL` diagnostics (PR #147115)

Finn Plummer via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Jul 8 13:58:24 PDT 2025


================
@@ -130,12 +149,13 @@ class SemaHLSL : public SemaBase {
 
   /// Creates the Root Signature decl of the parsed Root Signature elements
   /// onto the AST and push it onto current Scope
-  void ActOnFinishRootSignatureDecl(
-      SourceLocation Loc, IdentifierInfo *DeclIdent,
-      SmallVector<llvm::hlsl::rootsig::RootElement> &Elements);
+  void
+  ActOnFinishRootSignatureDecl(SourceLocation Loc, IdentifierInfo *DeclIdent,
+                               ArrayRef<hlsl::RootSignatureElement> Elements);
 
   // Returns true when D is invalid and a diagnostic was produced
----------------
inbelic wrote:

```suggestion
  // Returns true if any RootSignatureElement is invalid and a diagnostic was produced
```

https://github.com/llvm/llvm-project/pull/147115


More information about the llvm-branch-commits mailing list