[llvm-branch-commits] [llvm] 6072d75 - fix jmmartinez's comments

[via llvm-branch-commits]

Author: shore
Date: 2025-07-08T08:55:33+08:00
New Revision: 6072d751726616fc4c88d856fadc857e4afab884

URL: https://github.com/llvm/llvm-project/commit/6072d751726616fc4c88d856fadc857e4afab884
DIFF: https://github.com/llvm/llvm-project/commit/6072d751726616fc4c88d856fadc857e4afab884.diff

LOG: fix jmmartinez's comments

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
    llvm/test/lit.cfg.py

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp b/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
index 9557475769768..3cf21b2d80daa 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
@@ -4561,9 +4561,9 @@ static SrcStatus getNegStatus(Register Reg, SrcStatus S,
     }
     break;
   default:
-    llvm_unreachable("unexpected SrcStatus");
+    break;
   }
-  llvm_unreachable("unexpected SrcStatus");
+  llvm_unreachable("unexpected SrcStatus & NegType combination");
 }
 
 static std::optional<std::pair<Register, SrcStatus>>

diff  --git a/llvm/test/lit.cfg.py b/llvm/test/lit.cfg.py
index fddade78df9b6..bd6e37c848d8c 100644
--- a/llvm/test/lit.cfg.py
+++ b/llvm/test/lit.cfg.py
@@ -474,7 +474,7 @@ def have_cxx_shared_library():
         print("could not exec llvm-readobj")
         return False
 
-    readobj_out = readobj_cmd.stdout.read().decode("utf-8")
+    readobj_out = readobj_cmd.stdout.read().decode("ascii")
     readobj_cmd.wait()
 
     regex = re.compile(r"(libc\+\+|libstdc\+\+|msvcp).*\.(so|dylib|dll)")