[llvm-branch-commits] [lldb] 59e812f - [lldb][test] Skip pointer to std::unordered_map formatter tests on older Clang versions

[Michael Buch via llvm-branch-commits]

Author: Michael Buch
Date: 2025-07-04T07:39:13+01:00
New Revision: 59e812f2eed8be9674efa42cdbfe4a9d1fb57052

URL: https://github.com/llvm/llvm-project/commit/59e812f2eed8be9674efa42cdbfe4a9d1fb57052
DIFF: https://github.com/llvm/llvm-project/commit/59e812f2eed8be9674efa42cdbfe4a9d1fb57052.diff

LOG: [lldb][test] Skip pointer to std::unordered_map formatter tests on older Clang versions

These only work after https://github.com/llvm/llvm-project/pull/143501 and https://github.com/llvm/llvm-project/pull/144517. Skip on older compilers. This currently fails on the macOS matrix bots that run the LLDB test-suite with older Clang versions.

See https://github.com/llvm/llvm-project/issues/146040.

Added: 
    

Modified: 
    lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unordered_map-iterator/TestDataFormatterLibccUnorderedMap.py
    lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unordered_map-iterator/main.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unordered_map-iterator/TestDataFormatterLibccUnorderedMap.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unordered_map-iterator/TestDataFormatterLibccUnorderedMap.py
index bf103aa78baba..a338e3c12598e 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unordered_map-iterator/TestDataFormatterLibccUnorderedMap.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unordered_map-iterator/TestDataFormatterLibccUnorderedMap.py
@@ -105,7 +105,21 @@ def test_iterator_formatters(self):
             type="const StringMapT *const &",
         )
 
-        lldbutil.continue_to_breakpoint(process, bkpt)
+    @expectedFailureAll(
+        bugnumber="https://github.com/llvm/llvm-project/issues/146040",
+        compiler="clang",
+        compiler_version=["<", "21"],
+    )
+    @add_test_categories(["libc++"])
+    def test_ptr_formatters(self):
+        """
+        Test that pointers to std::unordered_map are formatted correctly.
+        """
+
+        self.build()
+        (self.target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
+            self, "Stop here", lldb.SBFileSpec("main.cpp", False)
+        )
 
         self.check_ptr_or_ref("ptr1")
         self.check_ptr_or_ref("ptr2")

diff  --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unordered_map-iterator/main.cpp b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unordered_map-iterator/main.cpp
index 26cbb9476119d..5397e54d99545 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unordered_map-iterator/main.cpp
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unordered_map-iterator/main.cpp
@@ -16,7 +16,7 @@ static void check_references(const StringMapT &ref1, StringMapT &ref2,
 static void check_pointer(const StringMapT *ptr1, StringMapT *ptr2,
                           StringMapTPtr ptr3, StringMapTPtr *ptr4,
                           const StringMapT *const *ptr5, StringMapT **ptr6) {
-  std::printf("Break here");
+  std::printf("Stop here");
 }
 
 int main() {