[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Implement Parsing of Descriptor Tables (PR #122982)

Finn Plummer via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Jan 28 14:16:29 PST 2025


inbelic wrote:

Updated to include diagnostics output and the relevant testing.

I have rebased to split the pr into smaller incremental changes, to help with review. And I have taken care to address all previous comments. Unfortunately the rebase causes these comments to get lost :/

I have implemented the suggestion to use `std::variant` to model the `RootElement` data-type, re-used the `dxil::ResourceClass` for `ClauseType`.

Notably though, there was some bigger changes introduced to handle that the optional parameters can be specified in any order.

https://github.com/llvm/llvm-project/pull/122982


More information about the llvm-branch-commits mailing list