[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP][flang] make private variable allocation implicit in omp.private (PR #124019)

[Kareem Ergawy via llvm-branch-commits]

================
@@ -132,7 +168,7 @@ void DataSharingProcessor::cloneSymbol(const semantics::Symbol *sym) {
 
   if (needInitClone()) {
     Fortran::lower::initializeCloneAtRuntime(converter, *sym, symTable);
-    callsInitClone = true;
+    mightHaveReadMoldArg = true;
----------------
ergawy wrote:

The name of this field is a bit confusing because:
1. it does not specify where the mold arg comes from (in this case it is the `init` region's mold arg),
2. its use here, somewhat implies that `DataSharingProcessor::cloneSymbol` is exclusively called for the delayed privatization case, which seems to be the opposite looking the changes below.

Maybe it can be named: `initializedCloneFromHostSym`, or something similar?

https://github.com/llvm/llvm-project/pull/124019