[llvm-branch-commits] [llvm] [tablegen] Implement multiple outputs for patterns (PR #123775)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Jan 21 08:28:21 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 3fa2cf6b1a6a4509635c2c90bed2876beb748110 7e7ba17845cd66e3fcbbe19097f4a60407e13ef4 --extensions cpp,h -- llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp llvm/utils/TableGen/Common/CodeGenDAGPatterns.h llvm/utils/TableGen/DAGISelEmitter.cpp llvm/utils/TableGen/DAGISelMatcherGen.cpp llvm/utils/TableGen/FastISelEmitter.cpp llvm/utils/TableGen/GlobalISelEmitter.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
index fcff67b030..858910ab39 100644
--- a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
@@ -2810,7 +2810,7 @@ TreePattern::TreePattern(const Record *TheRec,
 
 TreePattern TreePattern::clone() const {
   TreePattern New = *this;
-  for(TreePatternNodePtr& Tree : New.Trees)
+  for (TreePatternNodePtr &Tree : New.Trees)
     Tree = Tree->clone();
   return New;
 }
@@ -2828,7 +2828,6 @@ bool TreePattern::hasProperTypeByHwMode() const {
                       [](auto &T) { return T->hasProperTypeByHwMode(); });
 }
 
-
 void TreePattern::ComputeNamedNodes() {
   for (TreePatternNodePtr &Tree : Trees)
     ComputeNamedNodes(*Tree);
@@ -4392,10 +4391,10 @@ void CodeGenDAGPatterns::ParseOnePattern(
   // tree which has possible types.
   for (const auto &InTree : Pattern.getTrees()) {
     if (InTree->hasPossibleType())
-      AddPatternToMatch(&Pattern,
-                        PatternToMatch(TheDef, Preds, InTree,
-                                       ExpandedOutPattern, InstImpResults,
-                                       Complexity, TheDef->getID(), ShouldIgnore));
+      AddPatternToMatch(
+          &Pattern, PatternToMatch(TheDef, Preds, InTree, ExpandedOutPattern,
+                                   InstImpResults, Complexity, TheDef->getID(),
+                                   ShouldIgnore));
   }
 }
 
@@ -4464,9 +4463,9 @@ void CodeGenDAGPatterns::ExpandHwModeBasedTypes() {
         return;
 
     PatternsToMatch.emplace_back(P.getSrcRecord(), P.getPredicates(),
-                                 std::move(NewSrc), NewDst,
-                                 P.getDstRegs(), P.getAddedComplexity(),
-                                 getNewUID(), P.getGISelShouldIgnore(), Check);
+                                 std::move(NewSrc), NewDst, P.getDstRegs(),
+                                 P.getAddedComplexity(), getNewUID(),
+                                 P.getGISelShouldIgnore(), Check);
   };
 
   for (PatternToMatch &P : Copy) {
diff --git a/llvm/utils/TableGen/FastISelEmitter.cpp b/llvm/utils/TableGen/FastISelEmitter.cpp
index d5f850be44..a452640078 100644
--- a/llvm/utils/TableGen/FastISelEmitter.cpp
+++ b/llvm/utils/TableGen/FastISelEmitter.cpp
@@ -591,8 +591,7 @@ void FastISelMap::collectPatterns(const CodeGenDAGPatterns &CGP) {
     // Ok, we found a pattern that we can handle. Remember it.
     InstructionMemo Memo(
         Pattern.getDstPattern().getOnlyTree()->getOperator()->getName(), DstRC,
-        std::move(SubRegNo), std::move(PhysRegInputs),
-                         PredicateCheck);
+        std::move(SubRegNo), std::move(PhysRegInputs), PredicateCheck);
 
     int complexity = Pattern.getPatternComplexity(CGP);
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/123775


More information about the llvm-branch-commits mailing list