[llvm-branch-commits] [YAML] Don't validate `Fill::Size` after error (PR #123280)

[Vitaly Buka via llvm-branch-commits]

================
@@ -1750,7 +1750,9 @@ void MappingTraits<std::unique_ptr<ELFYAML::Chunk>>::mapping(
 std::string MappingTraits<std::unique_ptr<ELFYAML::Chunk>>::validate(
     IO &io, std::unique_ptr<ELFYAML::Chunk> &C) {
   if (const auto *F = dyn_cast<ELFYAML::Fill>(C.get())) {
-    if (F->Pattern && F->Pattern->binary_size() != 0 && !F->Size)
+    // Can't check the `Size`, as it's required and may be left uninitialized by
----------------
vitalybuka wrote:

Actually I don't see a problem to just require:
If you do custom validate, be aware that required fields can be garbage.

On a quick look, only this and `MappingTraits<MachOYAML::Section>::validate(IO &IO,` are affected


https://github.com/llvm/llvm-project/pull/123280