[llvm-branch-commits] [YAML] Don't validate `Fill::Size` after error (PR #123280)

Fangrui Song via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Jan 16 21:35:38 PST 2025


================
@@ -1750,7 +1750,9 @@ void MappingTraits<std::unique_ptr<ELFYAML::Chunk>>::mapping(
 std::string MappingTraits<std::unique_ptr<ELFYAML::Chunk>>::validate(
     IO &io, std::unique_ptr<ELFYAML::Chunk> &C) {
   if (const auto *F = dyn_cast<ELFYAML::Fill>(C.get())) {
-    if (F->Pattern && F->Pattern->binary_size() != 0 && !F->Size)
+    // Can't check the `Size`, as it's required and may be left uninitialized by
----------------
MaskRay wrote:

`// F->Size might be uninitialized if .... Guard it with !io.error()`

I am curious how this happens. Change the PR description to mention it?

https://github.com/llvm/llvm-project/pull/123280


More information about the llvm-branch-commits mailing list