[llvm-branch-commits] [clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support AMDGPU's generic target (PR #122629)

Shilei Tian via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Jan 14 10:09:15 PST 2025


shiltian wrote:

> Still, I think it is possible to make it generic with minor assumption. Let's say you are now about to parsing the final part of the target ID string which may be either "env-cpu" or "cpu" without env.

This is not actually the issue. The issue is when the cpu is a generic target, such as `gfx10-3-generic`. By the current logic, the target id after split is `generic`, which is totally a valid one, and leave the rest with things like `hip-amd-amdhsa-amd-gfx10-3`.

https://github.com/llvm/llvm-project/pull/122629


More information about the llvm-branch-commits mailing list