[llvm-branch-commits] [llvm] [mlir] [OMPIRBuilder][MLIR] Add support for target 'if' clause (PR #122478)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Jan 14 07:35:17 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 364cd46360d7a5d2a79ae9bf516f23c4840ff09b 8c348ba2796e08d45fe167d52db0fe047eaafa8a --extensions cpp,h -- llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
index d29e22c762..273470b2ba 100644
--- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
+++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
@@ -7423,34 +7423,36 @@ emitTargetCall(OpenMPIRBuilder &OMPBuilder, IRBuilderBase &Builder,
 
     SmallVector<Value *, 3> NumTeamsC;
     for (auto [DefaultVal, RuntimeVal] :
-        zip_equal(DefaultAttrs.MaxTeams, RuntimeAttrs.MaxTeams))
-      NumTeamsC.push_back(RuntimeVal ? RuntimeVal : Builder.getInt32(DefaultVal));
+         zip_equal(DefaultAttrs.MaxTeams, RuntimeAttrs.MaxTeams))
+      NumTeamsC.push_back(RuntimeVal ? RuntimeVal
+                                     : Builder.getInt32(DefaultVal));
 
-    // Calculate number of threads: 0 if no clauses specified, otherwise it is the
-    // minimum between optional THREAD_LIMIT and NUM_THREADS clauses.
+    // Calculate number of threads: 0 if no clauses specified, otherwise it is
+    // the minimum between optional THREAD_LIMIT and NUM_THREADS clauses.
     auto InitMaxThreadsClause = [&Builder](Value *Clause) {
       if (Clause)
         Clause = Builder.CreateIntCast(Clause, Builder.getInt32Ty(),
-                                      /*isSigned=*/false);
+                                       /*isSigned=*/false);
       return Clause;
     };
     auto CombineMaxThreadsClauses = [&Builder](Value *Clause, Value *&Result) {
       if (Clause)
-        Result = Result
-                    ? Builder.CreateSelect(Builder.CreateICmpULT(Result, Clause),
-                                            Result, Clause)
-                    : Clause;
+        Result =
+            Result ? Builder.CreateSelect(Builder.CreateICmpULT(Result, Clause),
+                                          Result, Clause)
+                   : Clause;
     };
 
     // If a multi-dimensional THREAD_LIMIT is set, it is the OMPX_BARE case, so
     // the NUM_THREADS clause is overriden by THREAD_LIMIT.
     SmallVector<Value *, 3> NumThreadsC;
-    Value *MaxThreadsClause = RuntimeAttrs.TeamsThreadLimit.size() == 1
-                                  ? InitMaxThreadsClause(RuntimeAttrs.MaxThreads)
-                                  : nullptr;
+    Value *MaxThreadsClause =
+        RuntimeAttrs.TeamsThreadLimit.size() == 1
+            ? InitMaxThreadsClause(RuntimeAttrs.MaxThreads)
+            : nullptr;
 
-    for (auto [TeamsVal, TargetVal] : zip_equal(RuntimeAttrs.TeamsThreadLimit,
-                                                RuntimeAttrs.TargetThreadLimit)) {
+    for (auto [TeamsVal, TargetVal] : zip_equal(
+             RuntimeAttrs.TeamsThreadLimit, RuntimeAttrs.TargetThreadLimit)) {
       Value *TeamsThreadLimitClause = InitMaxThreadsClause(TeamsVal);
       Value *NumThreads = InitMaxThreadsClause(TargetVal);
 
@@ -7466,13 +7468,13 @@ emitTargetCall(OpenMPIRBuilder &OMPBuilder, IRBuilderBase &Builder,
     uint32_t SrcLocStrSize;
     Constant *SrcLocStr = OMPBuilder.getOrCreateDefaultSrcLocStr(SrcLocStrSize);
     Value *RTLoc = OMPBuilder.getOrCreateIdent(SrcLocStr, SrcLocStrSize,
-                                              llvm::omp::IdentFlag(0), 0);
+                                               llvm::omp::IdentFlag(0), 0);
 
     Value *TripCount = RuntimeAttrs.LoopTripCount
-                          ? Builder.CreateIntCast(RuntimeAttrs.LoopTripCount,
-                                                  Builder.getInt64Ty(),
-                                                  /*isSigned=*/false)
-                          : Builder.getInt64(0);
+                           ? Builder.CreateIntCast(RuntimeAttrs.LoopTripCount,
+                                                   Builder.getInt64Ty(),
+                                                   /*isSigned=*/false)
+                           : Builder.getInt64(0);
 
     // TODO: Use correct DynCGGroupMem
     Value *DynCGGroupMem = Builder.getInt32(0);

``````````

</details>


https://github.com/llvm/llvm-project/pull/122478


More information about the llvm-branch-commits mailing list