[llvm-branch-commits] [mlir] [mlir][rocdl] Add AMDGPU-specific `cf.assert` lowering (PR #121067)

Joseph Huber via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Jan 3 06:54:18 PST 2025


jhuber6 wrote:

> 1. Approved
> 
>     2. Wrt OpenCL ... I hope legalization didn't get broken, but in the OpenCL flow, pryntf should lower to ... `printf()`, which the compiler will handle. Or at least that's my recollection of how that goes from staring at the AMDGPU backend ~a year ago

It's complicated, there's like two different flows that either lower `printf` to AMD's hostcall version or to a ring buffer type affair, then if you suppress the transform you just get `printf` symbols which is what my implementation uses.

https://github.com/llvm/llvm-project/pull/121067


More information about the llvm-branch-commits mailing list