[llvm-branch-commits] [llvm] [HLSL] Refactor Offset calculation while writing Root Signatures. (PR #128577)

Damyan Pepper via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Feb 25 12:39:26 PST 2025


================
@@ -12,44 +12,59 @@
 using namespace llvm;
 using namespace llvm::mcdxbc;
 
+void setRewrite(raw_ostream &Stream, uint32_t &Offset) {
----------------
damyanp wrote:

I think these two functions are only used from within this cpp.  Should either be marked as static, or in an anonymous namespace, to make that clear.

(I'm not sure what LLVM's preference is between static / anonymous namespace)

https://github.com/llvm/llvm-project/pull/128577


More information about the llvm-branch-commits mailing list