[llvm-branch-commits] [llvm] [HLSL] Refactor Offset calculation while writing Root Signatures. (PR #128577)
Damyan Pepper via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Mon Feb 24 18:16:17 PST 2025
================
@@ -25,7 +25,7 @@ Parts:
# CHECK-NEXT: RootSignature:
# CHECK-NEXT: Version: 2
# CHECK-NEXT: NumStaticSamplers: 0
-# CHECK-NEXT: StaticSamplersOffset: 24
+# CHECK-NEXT: StaticSamplersOffset: 0
----------------
damyanp wrote:
This suggests that this is a functional change. Maybe at least mention in the PR description / commit message why it's expected that these values have changed? Or maybe it's actually desireable that we fix it so that these get set to a value?
https://github.com/llvm/llvm-project/pull/128577
More information about the llvm-branch-commits
mailing list