[llvm-branch-commits] [llvm] [HLSL] Refactor Offset calculation while writing Root Signatures. (PR #128577)
Justin Bogner via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Mon Feb 24 13:10:28 PST 2025
================
@@ -7,19 +7,42 @@
//===----------------------------------------------------------------------===//
#include "llvm/BinaryFormat/DXContainer.h"
-#include <cstdint>
-#include <limits>
+#include "llvm/Support/BinaryStreamWriter.h"
+#include "llvm/Support/raw_ostream.h"
+#include <map>
+#include <string>
----------------
bogner wrote:
We probably don't want to use `std::map` and `std::string` here - see the section on [picking-the-right-data-structure-for-a-task](https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task) from the LLVM programmer's manual for some good guidelines.
https://github.com/llvm/llvm-project/pull/128577
More information about the llvm-branch-commits
mailing list