[llvm-branch-commits] [clang] [clang][NFC] Remove CXXRecordDecl::lookupDependentName() and its helpers (PR #128392)

[Nathan Ridge via llvm-branch-commits]

HighCommander4 wrote:

> LGTM in general, but my concern would be that we're less clear about the number of uses of this function out-of-tree (and how hard it could be to migrate them to HeuristicResolver), so as an alternative, can we turn the implementation to use HeuristicResolver and explicitly deprecate it for a while before eventually removing it?

I tried this, but this would require linking `clangSema` into `clang/lib/AST` which creates a circular dependency.

FWIW I did a Github code search and could only find [one](https://github.com/sourcegraph/scip-clang/blob/cc64149ae5f7819ac34c987807753b440c681b6a/indexer/ApproximateNameResolver.cc#L69) out-of-tree use in public code available on Github, and it looks straightforward to port to HeuristicResolver.

https://github.com/llvm/llvm-project/pull/128392