[llvm-branch-commits] [clang] [clang] Implement instantiation context note for checking template parameters (PR #126088)

[Matheus Izvekov via llvm-branch-commits]

================
@@ -1018,9 +1019,9 @@ namespace cwg62 { // cwg62: 2.9
   struct A {
     struct { int n; } b;
   };
-  template<typename T> struct X {};
-  template<typename T> T get() { return get<T>(); }
-  template<typename T> int take(T) { return 0; }
+  template<typename T> struct X {}; // cxx98-note 6{{template parameter is declared here}}
----------------
mizvekov wrote:

Yeah, I was in a break at that time because I was moving to a different country. I was quite surprised when I ran into it later.

There was no discussion about these points I raised on that PR, was there any other discussions in other mediums, like Discourse?

I think the more important question is, do we need this amount of detail for the diagnostic messages of DR tests specifically, what makes them more special than the other tests in this case?

https://github.com/llvm/llvm-project/pull/126088