[llvm-branch-commits] [llvm] AMDGPU: Extract lambda used in foldImmediate into a helper function (PR #127484)
Shilei Tian via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Mon Feb 17 08:54:07 PST 2025
================
@@ -3446,25 +3470,6 @@ bool SIInstrInfo::foldImmediate(MachineInstr &UseMI, MachineInstr &DefMI,
if (!getConstValDefinedInReg(DefMI, Reg, Imm))
----------------
shiltian wrote:
<!--__GRAPHITE_HTML_TAG_START__--><p class='graphite__hidden'><i>[Re: line +3469]</i></p><!--__GRAPHITE_HTML_TAG_END__-->
nit: I'd still prefer to initialize it even though if `getConstValDefinedInReg` returns `true`, it will be initialized.
<!--__GRAPHITE_HTML_TAG_START__--><p class='graphite__hidden'>See this comment inline on <a href="https://app.graphite.dev/github/pr/llvm/llvm-project/127484?utm_source=unchanged-line-comment">Graphite</a>.</p><!--__GRAPHITE_HTML_TAG_END__-->
https://github.com/llvm/llvm-project/pull/127484
More information about the llvm-branch-commits
mailing list