[llvm-branch-commits] [llvm] [ReleaseNotes][RemoveDIs] Add release note for deprecated insertion methods (PR #127493)

[Orlando Cazalet-Hyams via llvm-branch-commits]

================
@@ -116,6 +116,8 @@ Changes to the LLVM IR
 Changes to LLVM infrastructure
 ------------------------------
 
+ * Several methods that use Instruction pointers as insertion positions (moveBefore, getFirstNonPHI) have been deprecated in favour of overloads and variants that use `BasicBlock::iterator`s instead. The instruction-flavoured methods will be removed in a future release. This work is part of the [RemoveDIs](https://llvm.org/docs/RemoveDIsDebugInfo.html) project, the documentation for which contains instructions for updating call-sites using the deprecated methods.
----------------
OCHyams wrote:

> Couple of nits from me (sorry).

... that github ate.

I think there's some unnecessary ambiguity around whether `moveBefore` + `getFirstNonPHI` is the complete list of affected functions or not (I think both the word "several" and then having those two in parens is causing it). Can we be more precise?

Secondly, IMO I think changing "instruction-flavoured" to "pointer-flavoured" slightly improves clarity. YMMV though. 

https://github.com/llvm/llvm-project/pull/127493