[llvm-branch-commits] [clang] [HLSL] Constant buffers codegen (PR #124886)

[Farzon Lotfi via llvm-branch-commits]

================
@@ -56,9 +75,18 @@ llvm::Type *DirectXTargetCodeGenInfo::getHLSLType(CodeGenModule &CGM,
 
     return llvm::TargetExtType::get(Ctx, TypeName, {ElemType}, Ints);
   }
-  case llvm::dxil::ResourceClass::CBuffer:
-    llvm_unreachable("dx.CBuffer handles are not implemented yet");
-    break;
+  case llvm::dxil::ResourceClass::CBuffer: {
+    QualType ContainedTy = ResType->getContainedType();
+    if (ContainedTy.isNull() || !ContainedTy->isStructureType())
----------------
farzonl wrote:

why would we return nullptr if the ContainedTy ia not struct? seems like we could return back a valid llvm::Type for this case?

https://github.com/llvm/llvm-project/pull/124886