[llvm-branch-commits] [mlir] 88f8956 - [mlir] Fix MLIRTestDialect dependency in MLIRTestIR

Nikita Popov via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Feb 11 07:48:53 PST 2025


Author: Nikita Popov
Date: 2025-02-11T14:59:41+01:00
New Revision: 88f8956711f7c8d306d08fff8603d6b99e8302c1

URL: https://github.com/llvm/llvm-project/commit/88f8956711f7c8d306d08fff8603d6b99e8302c1
DIFF: https://github.com/llvm/llvm-project/commit/88f8956711f7c8d306d08fff8603d6b99e8302c1.diff

LOG: [mlir] Fix MLIRTestDialect dependency in MLIRTestIR

This is a test library which is not part of libMLIR, so it should
use normal LINK_LIBS instead of mlir_target_link_libraries.

This fixes an issue introduced in #123910 and follows up on the
fix in #125004, which added the library to DEPENDS, which is not
sufficient.

Added: 
    

Modified: 
    mlir/test/lib/IR/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/mlir/test/lib/IR/CMakeLists.txt b/mlir/test/lib/IR/CMakeLists.txt
index e5416da70d500..71a96c7f92c0c 100644
--- a/mlir/test/lib/IR/CMakeLists.txt
+++ b/mlir/test/lib/IR/CMakeLists.txt
@@ -27,13 +27,15 @@ add_mlir_library(MLIRTestIR
   TestVisitorsGeneric.cpp
 
   EXCLUDE_FROM_LIBMLIR
+
+  LINK_LIBS PUBLIC
+  MLIRTestDialect
   )
 mlir_target_link_libraries(MLIRTestIR PUBLIC
   MLIRPass
   MLIRBytecodeReader
   MLIRBytecodeWriter
   MLIRFunctionInterfaces
-  MLIRTestDialect
   )
 
 target_include_directories(MLIRTestIR


        


More information about the llvm-branch-commits mailing list