[llvm-branch-commits] [llvm] 1ba8799 - [ORC] Add a FIXME. NFC.

[via llvm-branch-commits]

Author: Lang Hames
Date: 2025-02-08T16:19:54Z
New Revision: 1ba879965ff84ed4ef13b98b4144e23681a04d79

URL: https://github.com/llvm/llvm-project/commit/1ba879965ff84ed4ef13b98b4144e23681a04d79
DIFF: https://github.com/llvm/llvm-project/commit/1ba879965ff84ed4ef13b98b4144e23681a04d79.diff

LOG: [ORC] Add a FIXME. NFC.

(cherry picked from commit 7811c20bcd9d5b117a9543d74c71448fe9970fe6)

Added: 
    

Modified: 
    llvm/lib/ExecutionEngine/Orc/ExecutorProcessControl.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ExecutionEngine/Orc/ExecutorProcessControl.cpp b/llvm/lib/ExecutionEngine/Orc/ExecutorProcessControl.cpp
index b51fa24be76d1a1..a9dbcd166117b0c 100644
--- a/llvm/lib/ExecutionEngine/Orc/ExecutorProcessControl.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/ExecutorProcessControl.cpp
@@ -55,6 +55,9 @@ SelfExecutorProcessControl::SelfExecutorProcessControl(
       ExecutorAddr::fromPtr(&llvm_orc_deregisterEHFrameSectionWrapper);
 
 #ifdef __APPLE__
+  // FIXME: Don't add an UnwindInfoManager by default -- it's redundant when
+  //        the ORC runtime is loaded. We'll need a way to document this and
+  //        allow clients to choose.
   this->UnwindInfoMgr = UnwindInfoManager::TryCreate();
   if (this->UnwindInfoMgr)
     this->UnwindInfoMgr->addBootstrapSymbols(this->BootstrapSymbols);