[llvm-branch-commits] [clang] [HLSL] Constant buffers codegen (PR #124886)

Damyan Pepper via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Feb 7 20:42:01 PST 2025


================
@@ -5032,6 +5032,11 @@ class HLSLBufferDecl final : public NamedDecl, public DeclContext {
   SourceLocation KwLoc;
   /// IsCBuffer - Whether the buffer is a cbuffer (and not a tbuffer).
   bool IsCBuffer;
+  /// HasValidPackoffset - Whether the buffer has valid packoffset annotations
+  //                       on all declarations
+  bool HasPackoffset;
----------------
damyanp wrote:

I was looking around here because I was confused about why a validity check was calling `setHasPackoffset(IsValid)`.  The name in the comment - `HasValidPackoffset` - would not have confused me!

https://github.com/llvm/llvm-project/pull/124886


More information about the llvm-branch-commits mailing list