[llvm-branch-commits] [clang] [HLSL] Constant buffers codegen (PR #124886)

[Damyan Pepper via llvm-branch-commits]

================
@@ -257,8 +258,10 @@ static void validatePackoffset(Sema &S, HLSLBufferDecl *BufDecl) {
       VarDecl *NextVar = PackOffsetVec[i + 1].first;
       S.Diag(NextVar->getLocation(), diag::err_hlsl_packoffset_overlap)
           << NextVar << Var;
+      IsValid = false;
     }
   }
+  BufDecl->setHasPackoffset(IsValid);
----------------
damyanp wrote:

What is this for?  If I change this to `BufDecl->setHasPackoffset(true)` then the tests still pass.

https://github.com/llvm/llvm-project/pull/124886